Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC ......................................................................
Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/16/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 958: is_garbage_collected = true; > Look below at the comment and the DCHECK several lines below. It says it's It's not possible down below, because _after_ the flush starts, you can't get a _new_ reinsert. But you can have existing deltas in the 'REDO' list which are DELETE/REINSERT in the case of an MRS which has had alternating delete/insert _prior_ to the flush starting. -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
