Todd Lipcon has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4057/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 187: // Interrupted by a signal, do nothing. > I think so; returning here just means we'll poll the fd again, which will i ah, OK, I was thinking that libev was edge-triggered rather than level-triggered, but I remembered wrong: http://lists.schmorp.de/pipermail/libev/2010q4/001162.html -- To view, visit http://gerrit.cloudera.org:8080/4057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5f2be94c2e5cc0644a5bb2340adc4a71d844247 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
