Todd Lipcon has posted comments on this change. Change subject: Add trace metrics for maintenance ops, LBM writes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4172/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: Line 357: ADOPT_TRACE(trace.get()); > What does the ADOPT_TRACE change? Did this work before? the maintenance manager doesn't run in the context of an RPC, so there was no trace associated with the thread when it was running. So we have to manually construct one and adopt it here, or else the counters don't end up going anywhere. -- To view, visit http://gerrit.cloudera.org:8080/4172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39cd9438071aabbd2d7bdeca3269af8b83f2d55b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
