David Ribeiro Alves has posted comments on this change.

Change subject: WIP: tie log retention to consensus watermarks
......................................................................


Patch Set 1:

(3 comments)

partial review. back on it later (may wait a little bit to see if it stops 
being a WIP)

http://gerrit.cloudera.org:8080/#/c/4177/1//COMMIT_MSG
Commit Message:

Line 60: WIP because this needs some automated tests for the above behavior, and
would also be good to get an idea on what is the impact on startup. our 
bootstrap times already take a pretty long time, but this might mean they 
increase by a lot. at the very least this would help prioritize kudu-38


http://gerrit.cloudera.org:8080/#/c/4177/1/src/kudu/consensus/log.cc
File src/kudu/consensus/log.cc:

Line 650:         rem_segs <= FLAGS_log_max_segments_to_retain) {
idea (possibly unrelated to this patch), instead of a max segments to retain 
flag should we have a "max_percentage_of_drive_space" or something like that 
flag?


http://gerrit.cloudera.org:8080/#/c/4177/1/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

Line 173:   log::RetentionIndexes GetLogRetention() override;
rename to GetRetentionIndexes?


-- 
To view, visit http://gerrit.cloudera.org:8080/4177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc071270510f3dc3c65f88d615e93c6ffb26b12
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to