Alexey Serbin has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4134/8/src/kudu/tools/kudu-ts-cli-test.cc File src/kudu/tools/kudu-ts-cli-test.cc: Line 21: #include <gmock/gmock.h> Do we really need this header included here? PS8, Line 80: Status s I cannot see it's used in the code below. PS8, Line 99: ASSERT_OK(Subprocess::Call({ : GetTsCliToolPath(), : "--server_address", : cluster_->tablet_server(0)->bound_rpc_addr().ToString(), : "dump_tablet", : tablet_id : }, &out)); : int nrows = std::count(out.begin(), out.end(), '\n'); : ASSERT_GE(nrows, kNumRows); : ASSERT_THAT(out, testing::ContainsRegex("int32 key=")); : ASSERT_THAT(out, testing::ContainsRegex("int32 int_val=")); : ASSERT_THAT(out, testing::ContainsRegex("string string_val=hello world")); Does it make sense to separate the verification of the dump_tablet's output into a separate test? It seems that the current check is not very exhaustive: e.g., there isn't check that every row of the output contains those columns we want to see; no test for how NULL columns are shown (if shown at all) in the output, etc. -- To view, visit http://gerrit.cloudera.org:8080/4134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
