Alexey Serbin has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4303/2/src/kudu/util/mem_tracker.cc File src/kudu/util/mem_tracker.cc: Line 78: using std::shared_ptr; > Nit: not your fault, but this should precede std::string. Good catch! Somehow I missed that while re-ordering the rest of the 'using' directives. I'll fix this. -- To view, visit http://gerrit.cloudera.org:8080/4303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes