Todd Lipcon has posted comments on this change.

Change subject: KUDU-1582. Optimize budgeted compaction policy with an 
approximation
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4153/3/src/kudu/tablet/compaction_policy.cc
File src/kudu/tablet/compaction_policy.cc:

Line 294:     // If we know that the upper bound here is worse than our 
currently known
> Am I wrong in my understanding that what we're in fact doing here is that w
hrm, I think you explained it approximately right. I updated the comment, see 
if you think it's better this time around.


Line 414:   // do another pass using the real solver.
> maybe replace, "do another pass using the real solver" with "do another pas
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e611f161d66ddc47e97e3b5328bc1778a4ac958
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Anonymous Coward #174
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to