Jordan Birdsell has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 98: name = "no_replica_table" > what I mean was to wrap this in something like "for num_replicas in [1,3,5] Done, I added the iterative test for 1,3,5 provided they dont exceed the configured number of tservers which isnt allowed Line 111: self.client.delete_table(name) > I'm not a python expert, but isn't a finally block always executed? even if Fair point, changed it to catch the assertion error if the test fails. -- To view, visit http://gerrit.cloudera.org:8080/4315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
