Todd Lipcon has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4328/1/python/kudu/client.pyx File python/kudu/client.pyx: PS1, Line 357: dist(tserver) hm, might be more extensible to make this an actual class rather than returning dicts. (also, typo in 'dict') http://gerrit.cloudera.org:8080/#/c/4328/1/python/kudu/tests/common.py File python/kudu/tests/common.py: Line 141: while True: why not: while len(cls.client.....) < cls.NUM_TABLET_SERVERS? Line 144: elif time.time() > timeout: would be good to sleep for 50ms or something so you aren't tight-looping this RPC http://gerrit.cloudera.org:8080/#/c/4328/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 208: for tserver in self.client.list_tablet_servers(): seems like it's worth asserting at least that the result isn't an empty list -- To view, visit http://gerrit.cloudera.org:8080/4328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
