Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher ......................................................................
Patch Set 2: > How sure are we that this won't negatively affect the > non-auto-flush code path? i.e is this risky to pull into 1.0.0 so > late in the game? The auto-flush background task should not be run in any other mode except for AUTO_FLUSH_BACKGROUND, so that code should not be executed in other modes. That's why I think it's safe to pull into 1.0.0. -- To view, visit http://gerrit.cloudera.org:8080/4395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59825981a600f5882ee476479c2ddf16b495c1f9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
