Todd Lipcon has submitted this change and it was merged. Change subject: [client] avoid circular deps in time-based flusher ......................................................................
[client] avoid circular deps in time-based flusher The boost::bind() makes cast of parameters during the call, not during creation of the functor object: http://stackoverflow.com/questions/11255144/why-does-boostbind-store-arguments-of-the-type-passed-in-rather-than-of-the-ty So, it's necessary to pass weak pointers to the background auto-flush task to avoid circular dependencies between client::KuduSession::Data and rpc::Messenger. Besides, it does not make much sense to store shared reference to messenger in KuduSession::Data since it's always passed as a weak reference and then promoting to a shared one during the call in all usage scenarios. Thanks to Adar and Todd spotting the usual suspect there. This is a follow-up for 93be1310d227cf05025864654ca3f6713c2ddc2c. Change-Id: I59825981a600f5882ee476479c2ddf16b495c1f9 Reviewed-on: http://gerrit.cloudera.org:8080/4395 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins Tested-by: Todd Lipcon <t...@apache.org> (cherry picked from commit 1a062253e3fdc900a4b0b418520d2870b6de8846) Reviewed-on: http://gerrit.cloudera.org:8080/4403 Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59825981a600f5882ee476479c2ddf16b495c1f9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.0.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
