Todd Lipcon has posted comments on this change. Change subject: consensus: properly truncate all state when aborting operations ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4409/3/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: Line 184: virtual void TruncateOpsAfter(const OpId& op); > docs Done http://gerrit.cloudera.org:8080/#/c/4409/3/src/kudu/consensus/log_cache.h File src/kudu/consensus/log_cache.h: Line 103: // HasOpBeenWritten(), etc, will return as if the operations were never appended. > should we mention that this is not across restarts? Done http://gerrit.cloudera.org:8080/#/c/4409/3/src/kudu/integration-tests/log_verifier.cc File src/kudu/integration-tests/log_verifier.cc: Line 28: #include "kudu/util/metrics.h" > order Done Line 38: using strings::Substitute; > order Done Line 115: all_op_indexes.insert(index_term.first); > can we also test that we don't skip indexes somewhere? skipping COMMIT indexes should be allowed because of out-of-order commits in conjunction with log GC, right? Line 125: committed_terms.push_back(FindWithDefault(maps_by_ts[ts], index, -1)); > use a constant that maybe helps explain what this is doing? Done. Also switched to using boost::optional for the expected_term Line 153: > nit extra line Done -- To view, visit http://gerrit.cloudera.org:8080/4409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fb95b447991b7cadc2c403bc2596fead0bd31ad Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
