David Ribeiro Alves has posted comments on this change. Change subject: [c++client] performance optimizations ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 431: void Batcher::SetTimeoutMillis(uint32_t millis) { > Yes: check KuduSession::Data::SetTimeoutMillis() and KuduSession::Data::App our general informal policy has been to move away from uints and check for positivity, rather than changing it back IMO we should leave as it was. I don't feel strongly about it if you have a good reason though. -- To view, visit http://gerrit.cloudera.org:8080/4385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
