Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4505
to review the following change.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
ensure every gflag is defined outside of a namespace
The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.
Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
10 files changed, 60 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4505/1
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
