Todd Lipcon has posted comments on this change.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4480/2//COMMIT_MSG
Commit Message:

Line 19: Added formatting as `{asterisk}` as suggested.
Please consolidate the commit message so that it reads just as a summary of the 
total change (rather than containing the history of revisions of the patch).

The idea here is that, during code review, it's easy for us to just look at the 
different revisions to see what changed. But, the commit message becomes a 
permanent part of the source history, and if we look at the log in a year we 
won't really care that there was an earlier version of this patch that did 
something differently.

Hope that makes sense, sorry for the pedantry.


-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to