Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add IN-list predicate type ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/2986/7/src/kudu/client/scan_predicate-internal.h File src/kudu/client/scan_predicate-internal.h: Line 112: std::vector<KuduValue*> vals_; > is it possible to make this a vector<unique_ptr<KuduValue>>? That would ma This wasn't possible? http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc File src/kudu/client/scan_predicate.cc: Line 122: vector<const void*> vals_list; Size this up front with vals_.size()? -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
