Dan Burkert has posted comments on this change. Change subject: KUDU-1363: Add IN-list predicate type ......................................................................
Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: Line 38: using std::set; > warning: using decl 'set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/2986/7/src/kudu/client/scan_predicate-internal.h File src/kudu/client/scan_predicate-internal.h: Line 112: std::vector<KuduValue*> vals_; > This wasn't possible? It's possible, but it would require copying the vector<KuduValue*> into a vector<unique_ptr<KuduValue>> in the ctor. I think it's easier to just keep it the way it is. http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate-internal.h File src/kudu/client/scan_predicate-internal.h: Line 23: #include "kudu/client/value.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc File src/kudu/client/scan_predicate.cc: Line 120: Status InListPredicateData::AddToScanSpec(ScanSpec* spec, Arena* arena) { > warning: parameter 'arena' is unused [misc-unused-parameters] Not much I can do about this, it's a virtual method. Line 122: vector<const void*> vals_list; > Size this up front with vals_.size()? Done http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 181: if (values_.size() == 0) { > warning: the 'empty' method should be used to check for emptiness instead o Done -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
