David Ribeiro Alves has posted comments on this change.

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
......................................................................


Patch Set 4:

my point was that we should make sure to stress it a bit so that over time we 
will hit flush/flush async over different stages of the auto flushing.  The way 
you're doing it now, you always call flush at precise intervals, my suggestion 
was that you spin insert enough rows to actually get background batches being 
inserted while calling flush/flush async at random times, possibly increasing 
the coverage. would that make sense?

-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

Reply via email to