David Ribeiro Alves has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND ......................................................................
Patch Set 4: i'm ok with doing the test elsewhere, what you said about test running times make sense. that being said a test that tests for deadlocks on a multithreaded scenario should strive to have random call timing, which I don't think this one does. it always inserts, then waits a certain time then flushes, i.e. the pattern does not explore the overlap space which was what I was referring to. Any how some test is better than no test so I'm ok with merging this as is. -- To view, visit http://gerrit.cloudera.org:8080/4492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
