Alexey Serbin has submitted this change and it was merged. Change subject: [misc] : Remove few more warnings ......................................................................
[misc] : Remove few more warnings Observed few warnings with fresh builds: [365/1113] Building CXX object src/kudu/common/CMakeFiles/kudu_common_exported.dir/row_operations.cc.o ../../src/kudu/common/row_operations.cc: In member function ‘std::string kudu::DecodedRowOperation::ToString(const kudu::Schema&) const’: ../../src/kudu/common/row_operations.cc:58:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [403/1113] Building CXX object src/kudu/common/CMakeFiles/kudu_common.dir/row_operations.cc.o ../../src/kudu/common/row_operations.cc: In member function ‘std::string kudu::DecodedRowOperation::ToString(const kudu::Schema&) const’: ../../src/kudu/common/row_operations.cc:58:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [516/1113] Building CXX object src/kudu/benchmarks/CMakeFiles/rle.dir/rle.cc.o ../../src/kudu/benchmarks/rle.cc: In function ‘void kudu::BooleanRLE()’: ../../src/kudu/benchmarks/rle.cc:93:10: warning: variable ‘run_length’ set but not used [-Wunused-but-set-variable] size_t run_length; ^ [575/1113] Building CXX object src/kudu/cfile/CMakeFiles/cfile.dir/compression_codec.cc.o In file included from ../../src/kudu/cfile/compression_codec.h:24:0, from ../../src/kudu/cfile/compression_codec.cc:26: ../../src/kudu/gutil/macros.h:102:0: warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ ^ In file included from ../../thirdparty/installed-deps/include/snappy.h:45:0, from ../../src/kudu/cfile/compression_codec.cc:20: ../../thirdparty/installed-deps/include/snappy-stubs-public.h:79:0: note: this is the location of the previous definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ ^ Also added a trivial comment update. Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d Reviewed-on: http://gerrit.cloudera.org:8080/4518 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/benchmarks/rle.cc M src/kudu/codegen/row_projector.cc M src/kudu/common/row_operations.cc M src/kudu/gutil/macros.h 4 files changed, 7 insertions(+), 10 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/4518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>