Alexey Serbin has posted comments on this change. Change subject: build: fix codegen errors when using static linkage ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4540/1/CMakeLists.txt File CMakeLists.txt: Line 96: set(CMAKE_ENABLE_EXPORTS true) Just curious: would it be a better solution if adding MODULE specifier for the add_library() cmake directive in $REPO_ROOT/src/kudu/codegen/CMakeLists.txt ? Like add_library(codegen MODULE ...) as described at https://cmake.org/cmake/help/v3.2/command/add_library.html#id2 Probably, you already tried that and it didn't work, but just in case: it does not seem to be much harder than adding this in the top-level for all targets. -- To view, visit http://gerrit.cloudera.org:8080/4540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie803b93cfd9b5bed56ece5f24b769850b7b55b74 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
