Todd Lipcon has posted comments on this change.

Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: 
test_table_column
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4543/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 45:             assert frombytes(col.name) == name
given that column names should typically be human-readable (and are Strings in 
java rather than byte[]) should we have 'col.name' actually be a str rather 
than a bytes?


-- 
To view, visit http://gerrit.cloudera.org:8080/4543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to