Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4551/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS2, Line 499: in order to account for the latest appends Good find Dan, this is not a review but a curiosity Qn: Looking at the description/comments it seems like a racy situation between reader thread and a writer thread(I may have understood this wrong). Is there a guarantee here that the data_file_->Size is not changed after we grabbed the local_record.back() to inspect with CheckBlockRecord? PS2, Line 504: local_records.back() Nit: replace with record ? -- To view, visit http://gerrit.cloudera.org:8080/4551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68b04f1f1b8cd099120a220b1245ecf8f422770 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
