Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4551/5/src/kudu/integration-tests/open-readonly-fs-itest.cc File src/kudu/integration-tests/open-readonly-fs-itest.cc: PS5, Line 44: const char kTableName[] = "test-table"; : const int kNumColumns = 50; : const auto kTimeout = MonoDelta::FromSeconds(60); Sorry, I meant at the top of the TEST_F() method itself, but I guess this is OK too. PS5, Line 59: flush blocks Nit: "flush blocks" and "compaction blocks" isn't wrong, but it suggests that there is a difference in blocks between flushes and compactions, which isn't really the case. How about "we reduce the MRS flush threshold to increase flush frequency and increase the number of MM threads to encourage frequent compactions. The net effect of both of these changes: more blocks are written to disk." -- To view, visit http://gerrit.cloudera.org:8080/4551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68b04f1f1b8cd099120a220b1245ecf8f422770 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
