Dan Burkert has posted comments on this change.

Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 812:         del col_name_slice
box_value can throw, right?  Should everything between new Slice and del 
col_name_slice be in a try /finally?


-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to