Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4548/6/python/kudu/client.pyx File python/kudu/client.pyx: Line 816: # If list only contains a single value treat it as an This is already done by the C++ client, so you shouldn't need to do it here. Sorry I didn't see this before. Line 819: return self == values[0] is this returning a boolean? Line 827: vals.erase(vals.begin(), vals.end()) The issue isn't clearing the vector, but instead freeing all of the contained pointers. See, for example: https://github.com/apache/kudu/blob/master/src/kudu/gutil/stl_util.h#L401 -- To view, visit http://gerrit.cloudera.org:8080/4548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
