Alexey Serbin has posted comments on this change. Change subject: [c++ client] added few deprecation notes ......................................................................
Patch Set 2: (1 comment) > (1 comment) > > I think that the get/set latest timestamp APIs can be marked with > "unstable" or "experimental" or something, but I would delay actual > deprecation until there are replacements. Thank you for the feedback. I'll try to figure out whether it's possible to deliver that message via method/function attributes. As for now, I don't know how to do that. The only thing we can do in that regard is note-like doxygen attributes, so we can at least notify users of the API via the documentation. http://gerrit.cloudera.org:8080/#/c/4569/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 390: /// @deprecated This method is experimental and will either disappear or > is there a way to mark it as "unstable" instead of deprecated? seems more a Unfortunately, there is no way to do that with current version of doxygen. Instead of @deprecated, we could add one of those notice-like tags: @note @warning @attention What do you think is the best one in the context? But of course, we need to remove the deprecated attribute from the method's signature. And I don't know what to put there instead to notify users of the API on the 'unstable' status of this API. -- To view, visit http://gerrit.cloudera.org:8080/4569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
