Adar Dembo has posted comments on this change. Change subject: Replace some TSAN suppressions with annotations ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4593/1//COMMIT_MSG Commit Message: PS1, Line 10: It turns out that using suppressions : is rather inefficient: TSAN still needs to take the stack trace and feed : it to the external symbolizer program in order to compare the resulting : symbols against the suppression list. Interesting. Let me see if I'm understanding this correctly: 1. TSAN is always "active", looking for data races and the like. 2. When it finds one, it needs to check for a suppression. 3. First it collects a stack trace. 4. Then it invokes the external symbolizer to symbolize the trace. 5. Lastly, it compares the symbolized trace against the list of suppressions. Steps 4-5 are done with the global locks you mentioned held. By contrast, annotations prevent TSAN from checking certain bodies of code, obviating steps 2-5 completely. Is this correct? http://gerrit.cloudera.org:8080/#/c/4593/1/build-support/tsan-suppressions.txt File build-support/tsan-suppressions.txt: Line 47: race:google::GetStackTrace Is it now possible to remove this? I'm guessing not, but thought I'd ask. -- To view, visit http://gerrit.cloudera.org:8080/4593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b2f80e18cf84f58a30797bf2a355d3832a31b2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
