Todd Lipcon has posted comments on this change. Change subject: Replace some TSAN suppressions with annotations ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4593/1//COMMIT_MSG Commit Message: PS1, Line 10: It turns out that using suppressions : is rather inefficient: TSAN still needs to take the stack trace and feed : it to the external symbolizer program in order to compare the resulting : symbols against the suppression list. > Interesting. Let me see if I'm understanding this correctly: Yep, that's correct. http://gerrit.cloudera.org:8080/#/c/4593/1/build-support/tsan-suppressions.txt File build-support/tsan-suppressions.txt: Line 47: race:google::GetStackTrace > Is it now possible to remove this? I'm guessing not, but thought I'd ask. yea, it's not, because we call GetStackTrace in lots of places. I just annotated the one that was most frequent (based on pstacking some tests running in TSAN and looking for ReportRace in the stack traces). Didn't seem like it was worth wrapping the call and changing all the call sites. -- To view, visit http://gerrit.cloudera.org:8080/4593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b2f80e18cf84f58a30797bf2a355d3832a31b2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
