Jordan Birdsell has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4548/6/python/kudu/client.pyx File python/kudu/client.pyx: Line 816: col_name_slice = Slice(<char*> _name, len(_name)) > This is already done by the C++ client, so you shouldn't need to do it here Done Line 819: for val in values: > is this returning a boolean? no, the column class overrides the == comparison operator and instead creates a predicate. See the __richcmp__ method. At any rate, removed since this is addressed with the C++ client. Line 827: > The issue isn't clearing the vector, but instead freeing all of the contain Done -- To view, visit http://gerrit.cloudera.org:8080/4548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
