Todd Lipcon has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics ......................................................................
Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/2642/7/docs/design-docs/rpc-retry-and-failover.md File docs/design-docs/rpc-retry-and-failover.md: PS7, Line 58: d, : a- "implemented ad-hoc" (typo and no comma) PS7, Line 85: The RPC subsystem stores a volatile version of the response to send to : clients, but doesn't actually durably store the responses. this sounds sort of like the RPC system is durably storing completion records but not responses. Actually the entire completion record is volatile and we rebuild it entirely (ie the "response" portion and the "completion record" are treated the same way) PS7, Line 95: it's its PS7, Line 124: will work a should stick to present tense here: "acts as their ..." PS7, Line 124: an nit: a PS7, Line 131: than that PS7, Line 131: there these PS7, Line 145: determing determine PS7, Line 221: it's its PS7, Line 223: at of PS7, Line 223: a previous) : leade (a previous leader) -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2aa40486153b39724e1c9bd09c626b829274c6 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
