Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: PS1, Line 359: catch (InterruptedException ex) { : // We still need to finish cleaning up. : } > I guess if we really really want to be clean then yeah we'll have to wrap t Yeah, but I think we should. It's a tiny headache that makes this code robust should thread interruptions sneak back in via another test. -- To view, visit http://gerrit.cloudera.org:8080/4636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
