Adar Dembo has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 363:       }
> Checking...
Cool, so this worked out? Might want to add a comment explaining what's going 
on (that this cleanup depends on first waiting for all the processes to exit), 
to prevent someone from changing the order of this in the future and messing it 
up.


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to