Alexey Serbin has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4648/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: Line 191: TEST_F(SubprocessTest, TestGetExitStatusSignaled) { > I'm concerned about test flakiness. Once the subprocess is created, it coul Since cat without parameters is used as a laboratory mouse, the child process executing /bin/cat will await end-of-file in its standard input, so it looks safe and reliable to me (no data is fed to the /bin/cat input here). -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b16e2a2a53a01982f816b9ee41cc61fd93d4bf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
