Adar Dembo has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4648/4/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS4, Line 183: // If running under TSAN, then an attempt to send an interceptable signal : // makes TSAN to whine about signal-unsafe call inside of the glog's : // FailureSignalHandler() because glog signal handler allocated memory : // in FlushLogFilesUnsafe(). As an alternative, what do you think about suppressing FailureSignalHandler()? Actually, looks like we already tried to do this with "signal:logging_fail". But I guess that isn't having the desired effect? Or maybe not in this context? -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b16e2a2a53a01982f816b9ee41cc61fd93d4bf Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
