Alexey Serbin has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4648/7/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 556: CHECK(WIFEXITED(status) || WIFSIGNALED(status)); > I tried that -- my original update here was to use do {} while(!(CHECK(WIFE Correction: my original code was something like do {} while(!(WIFEXITED(status) || WIFSIGNALED(status))); And here is an update: in this configuration where we don't use WUNTRACED flag, the ptrace-related WSTOPPED can happenn only if the _parent_ process does the tracing. Since the parent does not do that, WSTOPPED cannot happen here. So, check for WSTOPPED is not needed here. -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b16e2a2a53a01982f816b9ee41cc61fd93d4bf Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
