Adar Dembo has posted comments on this change.

Change subject: [util] added Subprocess::GetExitStatus()
......................................................................


Patch Set 10:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4648/10/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

Line 313:     DCHECK(false) << err_str;
Nit: Use LOG(DFATAL) here, it's more idiomatic.


Line 470:     DCHECK(false) << err_str;
Nit: LOG(DFATAL) here too.


Line 484:     DCHECK(false) << err_str;
Nit: and here.


Line 500:     info =  Substitute("$0: process exited on signal $1", program_, 
status);
Nit: there's an extra space after the equals sign.


Line 510:     DCHECK(false) << info;
Nit: and here.


Line 590:     DCHECK(false) << err_str;
Nit: and here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b16e2a2a53a01982f816b9ee41cc61fd93d4bf
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to