Todd Lipcon has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4702/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 422: // TODO(mpercy): Consider using a separate Mutex for voting, which must sync to disk. > is this TODO invalid with the new mechanics? I think it's still valid, since we haven't actually cleaned up the locking yet (even though it's two classes, all the code paths still hold the same locks as they used to) -- To view, visit http://gerrit.cloudera.org:8080/4702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231273a1cfa92275788dd99c78e284ecd0543d7a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
