Todd Lipcon has posted comments on this change. Change subject: KUDU-1649 - [python] Add Binary Type Support ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4653/2/python/kudu/client.pyx File python/kudu/client.pyx: PS2, Line 2020: if isinstance(value, unicode): : value = value.encode('utf8') hrm, I'm not sure on this. If it's a binary column, shouldn't we force the user to explicitly encode? ie throw an error if they pass unicode? http://gerrit.cloudera.org:8080/#/c/4653/2/python/kudu/tests/util.py File python/kudu/tests/util.py: PS2, Line 222: Иордания haha -- To view, visit http://gerrit.cloudera.org:8080/4653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13539d040b754399c13031003a2cf64c71ba151 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes