Todd Lipcon has submitted this change and it was merged. Change subject: consensus: remove bits of dead code ......................................................................
consensus: remove bits of dead code We had some old code path in which PeerMessageQueue::AppendOperations() would previously return ServiceUnavailable indicating some kind of memory limit. However, I traced through the code and could only find one case in which it would return ServiceUnavailable: if the log itself is shut down. We expect that the lifecycle of the log is controlled such that this will never happen. So, the code path that tried to handle this is now just a CHECK, and I was able to remove some code that was only called in this (dead) case. Additionally removes some other unused typedefs and methods in ReplicaState. Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Reviewed-on: http://gerrit.cloudera.org:8080/4712 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <[email protected]> Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h 3 files changed, 4 insertions(+), 47 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
