Dan Burkert has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4799/5/CMakeLists.txt File CMakeLists.txt: PS5, Line 796: OpenSSL library. At least, using libcrypto from that. Just say "OpenSSL" to keep it consistent with the rest. We'll need libssl soon. Also, is there no need for ADD_THIRDPARTY_LIB(crypto SHARED_LIB "${OPENSSL_CRYPTO_LIBRARY}") I thought that would be required, but maybe it's implicit since you don't seem to have linking issues? -- To view, visit http://gerrit.cloudera.org:8080/4799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69c1da97e6d013a034aefda59988b593ae1d6304 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
