Alexey Serbin has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) ......................................................................
Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/4799/6/src/kudu/security/crypto/cert_management-test.cc File src/kudu/security/crypto/cert_management-test.cc: Line 22: #include <vector> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/4799/6/src/kudu/security/crypto/cert_management.h File src/kudu/security/crypto/cert_management.h: Line 115: Status GenerateKey(uint16_t num_bits, Key* key) const; > warning: function 'kudu::crypto::CertRequestGenerator::GenerateKey' has a d Done Line 118: Status GenerateRequest(const CertSubjectInfo& info, const Key& key, > warning: function 'kudu::crypto::CertRequestGenerator::GenerateRequest' has Done Line 122: static Status AddExtension(stack_st_X509_EXTENSION* ext, int nid, char* value); > warning: function 'kudu::crypto::CertRequestGenerator::AddExtension' has a Done Line 152: static Status LoadCert(const std::string& fpath, uni_ptr<X509>* result); > warning: function 'kudu::crypto::CertSigner::LoadCert' has a definition wit Done Line 153: static Status LoadKey(const std::string& fpath, uni_ptr<EVP_PKEY>* result); > warning: function 'kudu::crypto::CertSigner::LoadKey' has a definition with Done -- To view, visit http://gerrit.cloudera.org:8080/4799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69c1da97e6d013a034aefda59988b593ae1d6304 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
