Will Berkeley has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc ......................................................................
Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4852/2//COMMIT_MSG Commit Message: PS2, Line 9: - Please wrap the commit message at 72 chars/line PS2, Line 12: [1-9] [1-9]+ PS2, Line 14: auo spelling http://gerrit.cloudera.org:8080/#/c/4852/2/src/kudu/scripts/jira_updater.py File src/kudu/scripts/jira_updater.py: PS2, Line 51: * might as well be + PS2, Line 64: update_review_link If we update the review link, can we also change the status to 'In Review'? PS2, Line 66: Update the Jira Comments Forgot to change the copied docstring PS2, Line 73: no better way Any way to sanity-check it's the right field before we update it? Anyway it's probably fine. PS2, Line 74: ''' Is it PEP8 to have a multiline comment as a string literal? I know python otherwise doesn't have multiline comments... PS2, Line 88: print "update_id %s" %update_id logging or leftover? if logging, some of the other functions could use logging, and could use the logging module PS2, Line 90: If One line comment should use # PS2, Line 93: 'id': '3' Add quick comment doc'ing what id : 3 is PS2, Line 108: update_comment Each of these functions constructs a new jira object (jira connection)...can we construct it once and pass it in to the functions? -- To view, visit http://gerrit.cloudera.org:8080/4852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4519ee0b83f9af03ba55f0eacc0553e86a3f13ec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
