Will Berkeley has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4852/2/src/kudu/scripts/jira_updater.py File src/kudu/scripts/jira_updater.py: PS2, Line 51: re.search(r'\bKUDU-[0-9] Maybe this is too coarse. If the log output has a substring like "This doesn't fix KUDU-12345" and no other KUDU-*, won't it pick up KUDU-12345 and potentially mark it with a review when it shouldn't? Maybe we need to have a convention, like the informal one that the commit message starts with the relevant JIRA id, if there is one, and identify the issue through the convention rather than searching the whole message. -- To view, visit http://gerrit.cloudera.org:8080/4852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4519ee0b83f9af03ba55f0eacc0553e86a3f13ec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
