Adar Dembo has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 941: const string kTestDir = GetTestPath("test"); > Essentially, I wanted to do this: Hmm. Instead, maybe you can change the various RunAction routines to always capture stdout/stderr, call SCOPED_TRACE() on them, and then decide whether to pass them on to the caller or not? PS1, Line 974: tablet_server(k > No, this was a stale comment leftover, I think I was doing a WaitForServer OK. Why do we need to wait for 1000 rows to be inserted, though? http://gerrit.cloudera.org:8080/#/c/4834/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 121: STLDeleteValues(&ts_map_); This would be more robust if placed in ToolTest's destructor. PS2, Line 936: // Test 'kudu tablet copy' tool when the destination tablet server is online. : // 1. Test the copy tool when the destination replica is healthy : // 2. Test the copy tool when the destination replica is tombstoned : // 3. Test the copy tool when the destination replica is deleted : TEST_F(ToolTest, TestTabletCopy) { Should now refer to "remote_replica copy" rather than "tablet copy". http://gerrit.cloudera.org:8080/#/c/4834/2/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: Line 312: req.set_caller_term(std::numeric_limits<int64_t>::max()); AFAICT, this means that if the destination tserver already has this replica, we'll always blow it away. Was this an intentional choice? http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 916: > Done You added the new one, but you didn't chain the old variant into it. -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
