Adar Dembo has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 6: (3 comments) Looks good to me. I'll defer to Mike for the +2 from here on out. http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS1, Line 974: er_->tablet_ser > Sorry, I think I didn't understand your question clearly before. Test does Hmm, "replica catch-up" doesn't necessarily need to be in scope for this test. After all, we're just verifying the functionality of a CLI tool here, so verifying that the copy was successful (for some basic definition of "success") and that there's something on the other end is sufficient, I think. Anyway, since you've got it working, I guess it's fine to leave in, provided Mike thinks it's a good idea. http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS6, Line 1013: string expected = "Rejecting tablet copy request"; : ASSERT_STR_CONTAINS(stderr, expected); Nit: this text is only used in one place, so perhaps combine the two lines for brevity? http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: Line 299: RETURN_NOT_OK(GetServerStatus(dst_address, TabletServer::kDefaultPort, > Is there no way to override the port in these tools? Here and below. Seems I believe GetServerStatus() will use the port embedded in the first arg and only fall back to the default port (second arg) if there's no port in the first arg. -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
