Todd Lipcon has submitted this change and it was merged. Change subject: Fix SASL mechanism negotiation on the server side ......................................................................
Fix SASL mechanism negotiation on the server side This fixes the order in which the SASL server is initialized such that the mechanism list is set up before the sasl_server_init function is called. This is equivalent to the change made in Change ID I3c1b93045acd428ef3437597059c5106b03e25d0 on the client side. Without this change, the server would use a null mechanism list, which was being treated as a wildcard. The new test case configures a server to only accept GSSAPI, and then has a client configured to accept GSSAPI or PLAIN. Before the fix, it would negotiate PLAIN despite the attempt to require GSSAPI on the server side. Now, it properly negotiates. Change-Id: I4741ce618525311258d5ba61dd85f6f4721caf66 Reviewed-on: http://gerrit.cloudera.org:8080/4875 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/rpc/connection.cc M src/kudu/rpc/sasl_helper.cc M src/kudu/rpc/sasl_rpc-test.cc M src/kudu/rpc/sasl_server.cc 4 files changed, 85 insertions(+), 11 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4741ce618525311258d5ba61dd85f6f4721caf66 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
