Todd Lipcon has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4823/3/python/kudu/client.pyx File python/kudu/client.pyx: Line 2321: self._own = 1 I don't see any case where _own isn't true PS3, Line 2348: primary_key I don't think this kwarg is relevant, since you can't change the PKs of a table once created PS3, Line 2353: olumnSpec.default is this equivalent to just passing 'default=' kwarg? Line 2364: One of {'default', 'none', 'snappy', 'lz4', 'zlib'} see below Line 2367: One of {'auto', 'plain', 'prefix', 'group_varint', 'rle'} seems like it might be a pain to have to remember to update this doc if we add/remove encodings. I think just referencing the ENCODING_* list is safer -- To view, visit http://gerrit.cloudera.org:8080/4823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
