Adar Dembo has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method ......................................................................
Patch Set 2: (1 comment) Just passing through; not a real review. Logistically, what needs to happen in order for us to change this API without breaking compatibility? Or do we not care about compatibility here because Impala's Kudu dependency is versioned and well managed? http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java: PS2, Line 27: org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.escapeSQLString Can you use a {@link} here so that it's possible to navigate to it in an IDE? -- To view, visit http://gerrit.cloudera.org:8080/4934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b263d2444314d46533191918833840e75b7ba7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
