Dan Burkert has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method ......................................................................
Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java: PS2, Line 268: public > Does this need to be public? Yes it's used in Partition.formatRangePartition PS2, Line 271: ByteBuffer buf = ByteBuffer.wrap(key); > unused variable Done Line 274: > nit: extra blank line Done http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: PS2, Line 208: the tables > nit: this table's Done Line 223: if (!Iterators.all(partition.getHashBuckets().iterator(), Predicates.equalTo(0))) continue; > nit: I personally prefer if statements to not be on a single line, especial Done http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS2, Line 579: appendCellValueDebugString > nit: might as well put that in the enum itself. All of these methods depend heavily on the internal representation of the PartialRow, I don't think it should be exposed outside of this class. PS2, Line 785: Returns {@code true} if the cell values for the given column are equal in the two rows. > nit: that text should be in @return. Write something here that's like "Chec Done PS2, Line 804: + 1 > no +1 here for equals check Done PS2, Line 820: // Check that b is 1 byte longer than a, the extra byte is 0, and all other bytes are equal. > Stale/copy-paste comment Done PS2, Line 839: Returns > Same comment as above. Done http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java File java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java: PS2, Line 187: Pretty prints > nit: Technically this returns a string as opposed to actually printing some Done Line 190: */ > nit: add an @return Done -- To view, visit http://gerrit.cloudera.org:8080/4934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b263d2444314d46533191918833840e75b7ba7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
